Skip to content

docs(drupal): sync playground coverage#341

Merged
mberlofa merged 1 commit into
mainfrom
docs/drupal-template-standards-sync
Jul 6, 2026
Merged

docs(drupal): sync playground coverage#341
mberlofa merged 1 commit into
mainfrom
docs/drupal-template-standards-sync

Conversation

@mberlofa

@mberlofa mberlofa commented Jul 3, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Contributor

Summary

  • add drupal to the playground coverage allowlist required by the chart site-sync gate

Validation

  • make site-sync-check CHART=drupal
  • npm run lint
  • npm run format:check
  • npm run build
  • make release-check REPO=site
  • make attribution-check REPO=site

Chart PR: helmforgedev/charts#662
Issue: helmforgedev/charts#633

Summary by CodeRabbit

  • New Features
    • Added support for the Drupal chart in the playground, making it available in the synced chart selection flow.

@mberlofa mberlofa mentioned this pull request Jul 3, 2026
Merged
@coderabbitai

coderabbitai Bot commented Jul 3, 2026 •
edited
Loading

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: f3b02971-42aa-43a4-9e99-0c7b257d0f41

📥 Commits

Reviewing files that changed from the base of the PR and between 5f00a1f and 5f69ba7.

📒 Files selected for processing (1)
  • src/pages/playground.astro
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/pages/playground.astro
📝 Walkthrough

Walkthrough

Adds a drupal entry to the siteSyncPlaygroundConfigs slug map in src/pages/playground.astro, mapping it to src/data/playground-configs.ts so it is included in the playground chart sync set.

Changes

Playground Config Sync

Layer / File(s) Summary
Add drupal slug mapping
src/pages/playground.astro		 Adds a drupal entry to siteSyncPlaygroundConfigs, mapping it to src/data/playground-configs.ts.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

  • helmforgedev/site#322: Also extends src/pages/playground.astro by adding a chart slug to siteSyncPlaygroundConfigs.
  • helmforgedev/site#330: Also updates siteSyncPlaygroundConfigs in src/pages/playground.astro to register an additional chart slug.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title matches the main change: adding Drupal playground coverage to the sync allowlist.
Description check ✅ Passed The description covers the summary, validation steps, and linked issue/chart PR, though it uses a custom format instead of the template.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/drupal-template-standards-sync

Comment @coderabbitai help to get the list of available commands.

@mberlofa mberlofa mentioned this pull request Jul 3, 2026
Closed
mberlofa added a commit to helmforgedev/charts that referenced this pull request Jul 6, 2026
@mberlofa
fix(drupal): centralize template validation (#662)
7d36896 
## Summary
- add a centralized `drupal.validate` helper and
`templates/validate.yaml` entrypoint
- run existing database, replica, backup, and autoscaling validations
through the central entrypoint
- add fail-fast validation for ingress without hosts and reserved
selector-label overrides

## Validation
- helm unittest charts/drupal
- helm lint --strict charts/drupal
- make template-standards-check CHART=drupal
- make standards-check CHART=drupal
- make validate-chart CHART=drupal TIMEOUT=900: FULLY VALIDATED (17
layers)
- make site-sync-check CHART=drupal
- make release-check REPO=charts
- make attribution-check REPO=charts

Site PR: helmforgedev/site#341
Issue: #633

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

* **New Features**
  * Added chart validation checks that run during deployment rendering.
  * Enforced required ingress hosts when ingress is enabled.
* Prevented custom pod labels from overriding reserved selector labels.

* **Tests**
* Expanded validation coverage with cases for missing ingress hosts,
label conflicts, and nullable pod labels.
* Updated validation checks to run against the dedicated validation
template.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: MergeCheck <mergecheck@example.invalid>
@mberlofa mberlofa force-pushed the docs/drupal-template-standards-sync branch from 5f00a1f to 5f69ba7 Compare July 6, 2026 12:13
@mberlofa mberlofa merged commit decc251 into main Jul 6, 2026
6 checks passed
@mberlofa mberlofa deleted the docs/drupal-template-standards-sync branch July 6, 2026 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@mberlofa